BREAKING (potentially) - Bump docker version (Ubuntu 22.04 LTS)

webbertakken commented 1 year ago

Changes

This PR will change the rolling tag from v1 to v2. That means that it will always use the latest v2 docker image. This is a potentially breaking change, however we do not expect most people to experience problems with this upgrade.
Fixes a couple of vulnerabilities and a compilation error
Pin Volta versions (so that Volta users will automatically use the right versions of node and yarn)

Checklist

[x] Read the contribution guide and accept the code of conduct
[x] Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR in the documentation repo)
[x] Readme (updated or not needed)
[x] Tests (added, updated or not needed)

github-actions[bot] commented 1 year ago

Cat Gif

EliasVal commented 1 year ago

Small Question 😅 Why are Unity versions that have reached EOL are still having tests ran with? 2018.x, 2019.x and 2020.x have reached their EOL's a long while back and I think that support should be dropped for versions that Unity doesn't support themselves

webbertakken commented 1 year ago

Small Question 😅 Why are Unity versions that have reached EOL are still having tests ran with? 2018.x, 2019.x and 2020.x have reached their EOL's a long while back and I think that support should be dropped for versions that Unity doesn't support themselves

It's a great question. I think we probably should stop pushing images for them. The reason we haven't is that some of the rationale is brought up by a very small amount of people. And we miss things. You bringing it up is really much appreciated.

I've created an issue for it https://github.com/game-ci/docker/issues/220

webbertakken commented 1 year ago

Docker @ https://github.com/game-ci/docker/pull/216 Docs @ https://github.com/game-ci/documentation/pull/407

EliasVal commented 1 year ago

It's a great question. I think we probably should stop pushing images for them. The reason we haven't is that some of the rationale is brought up by a very small amount of people. And we miss things. You bringing it up is really much appreciated.

I've created an issue for it https://github.com/game-ci/docker/issues/220

Of course! I'd like to help with development and I've yet to sit down on my PC to actually make PRs so until now I've only helped with already existing issues and PRs :D The first issue I'm gonna tackle is probably this one :)

codecov-commenter commented 1 year ago

Codecov Report

Merging #556 (a728a40) into main (43e1280) will decrease coverage by 0.02%. The diff coverage is 100.00%.

:exclamation: Current head a728a40 differs from pull request most recent head 649ac6e. Consider uploading reports for the commit 649ac6e to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   36.97%   36.96%   -0.02%     
==========================================
  Files          77       77              
  Lines        3032     3033       +1     
  Branches      623      637      +14     
==========================================
  Hits         1121     1121              
- Misses       1758     1912     +154     
+ Partials      153        0     -153

Files Changed	Coverage Δ
...l/cloud-runner/providers/k8s/kubernetes-storage.ts	`10.90% <100.00%> (ø)`
...oud-runner/providers/k8s/kubernetes-task-runner.ts	`12.34% <100.00%> (ø)`
src/model/image-tag.ts	`48.88% <100.00%> (ø)`

... and 36 files with indirect coverage changes

sbergen commented 1 year ago

In case you are interested in an example of how this can break things, I'm sharing this just FYI:

I'm using a two year old custom image to generate docfx documentation, and the build fails when updating from v2 to v3. The error is a bit jarring, but I assume just updating the custom image should help. I'm not sure when I'll get to that, but I'll probably ask in Discord if I face any issues.

webbertakken commented 1 year ago

Thanks for sharing that input @sbergen!

game-ci / unity-builder