game-ci / unity-builder

Build Unity projects for different platforms
https://github.com/marketplace/actions/unity-builder
MIT License
845 stars 244 forks source link

License Activation fixes and Github Annotations #590

Closed AndrewKahr closed 10 months ago

AndrewKahr commented 11 months ago

Changes

Related PRs

Checklist

github-actions[bot] commented 11 months ago

Cat Gif

codecov-commenter commented 11 months ago

Codecov Report

Merging #590 (9e55d14) into main (7afabe7) will increase coverage by 0.00%. The diff coverage is 66.66%.

:exclamation: Current head 9e55d14 differs from pull request most recent head cb33afe. Consider uploading reports for the commit cb33afe to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/game-ci/unity-builder/pull/590/graphs/tree.svg?width=650&height=150&src=pr&token=eRCPplc2s1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci)](https://app.codecov.io/gh/game-ci/unity-builder/pull/590?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci) ```diff @@ Coverage Diff @@ ## main #590 +/- ## ======================================== Coverage 37.22% 37.22% ======================================== Files 77 76 -1 Lines 3060 3054 -6 Branches 649 610 -39 ======================================== - Hits 1139 1137 -2 - Misses 1771 1917 +146 + Partials 150 0 -150 ``` | [Files](https://app.codecov.io/gh/game-ci/unity-builder/pull/590?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci) | Coverage Δ | | |---|---|---| | [src/model/build-parameters.ts](https://app.codecov.io/gh/game-ci/unity-builder/pull/590?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci#diff-c3JjL21vZGVsL2J1aWxkLXBhcmFtZXRlcnMudHM=) | `90.00% <100.00%> (+0.60%)` | :arrow_up: | | [src/model/docker.ts](https://app.codecov.io/gh/game-ci/unity-builder/pull/590?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci#diff-c3JjL21vZGVsL2RvY2tlci50cw==) | `10.63% <ø> (ø)` | | | [src/model/image-environment-factory.ts](https://app.codecov.io/gh/game-ci/unity-builder/pull/590?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci#diff-c3JjL21vZGVsL2ltYWdlLWVudmlyb25tZW50LWZhY3RvcnkudHM=) | `3.70% <0.00%> (-3.44%)` | :arrow_down: | ... and [36 files with indirect coverage changes](https://app.codecov.io/gh/game-ci/unity-builder/pull/590/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci)
AndrewKahr commented 10 months ago

iOS build issue seems to be a Unity issue and not from the changes to the action