Additional Fixes and Improvements

[AndrewKahr]

Changes

• Windows now exits with the proper exit codes. This mirrors Ubuntu behavior properly now and means we do not need the error parsing logic to handle error conditions which means we should be back to v2 behavior.
• Allow customizing image registry/image version
• Only create the licensing directory on Mac if it doesn't already exist. Don't delete the folder on build complete. This means builds nominally shouldn't need sudo permissions, very useful for self-hosted runners.
• Pick correct architecture when installing macos editor to support both x86 and arm-based systems

Related Issues

• https://github.com/game-ci/unity-builder/issues/564
• https://github.com/game-ci/unity-builder/issues/563
• https://github.com/game-ci/unity-builder/issues/578
• https://github.com/game-ci/unity-builder/issues/572
• https://github.com/game-ci/unity-builder/issues/594
• https://github.com/game-ci/unity-builder/issues/595

Related PRs

• https://github.com/game-ci/unity-builder/pull/576: I believe this PR is no longer needed since the exit code should be working properly now
• https://github.com/game-ci/unity-builder/pull/591: Merging this in with this PR to get v4 out a bit quicker. Credit to @dcvz for providing this code
• https://github.com/game-ci/documentation/pull/433

Checklist

• [x] Read the contribution guide and accept the code of conduct
• [x] Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR in the documentation repo)
• [x] Readme (updated or not needed)
• [x] Tests (added, updated or not needed)

[github-actions[bot]]

[codecov-commenter]

Codecov Report

Merging #596 (6d40668) into main (caa0a81) will increase coverage by 0.06%. The diff coverage is 81.81%.

:exclamation: Current head 6d40668 differs from pull request most recent head e526ef5. Consider uploading reports for the commit e526ef5 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

[](https://app.codecov.io/gh/game-ci/unity-builder/pull/596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci) ```diff @@ Coverage Diff @@ ## main #596 +/- ## ========================================== + Coverage 37.22% 37.29% +0.06% ========================================== Files 76 76 Lines 3054 3057 +3 Branches 610 610 ========================================== + Hits 1137 1140 +3 Misses 1917 1917 ``` | [Files](https://app.codecov.io/gh/game-ci/unity-builder/pull/596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci) | Coverage Δ | | |---|---|---| | [src/model/build-parameters.ts](https://app.codecov.io/gh/game-ci/unity-builder/pull/596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci#diff-c3JjL21vZGVsL2J1aWxkLXBhcmFtZXRlcnMudHM=) | `90.00% <ø> (ø)` | | | [src/model/image-tag.ts](https://app.codecov.io/gh/game-ci/unity-builder/pull/596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci#diff-c3JjL21vZGVsL2ltYWdlLXRhZy50cw==) | `48.31% <100.00%> (-0.58%)` | :arrow_down: | | [src/model/input.ts](https://app.codecov.io/gh/game-ci/unity-builder/pull/596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci#diff-c3JjL21vZGVsL2lucHV0LnRz) | `88.27% <100.00%> (+0.33%)` | :arrow_up: | | [src/model/docker.ts](https://app.codecov.io/gh/game-ci/unity-builder/pull/596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci#diff-c3JjL21vZGVsL2RvY2tlci50cw==) | `10.63% <0.00%> (ø)` | | | [src/model/exec-with-error-check.ts](https://app.codecov.io/gh/game-ci/unity-builder/pull/596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci#diff-c3JjL21vZGVsL2V4ZWMtd2l0aC1lcnJvci1jaGVjay50cw==) | `13.33% <50.00%> (ø)` | |

[GabLeRoux]

:tada: awesome! :D