Ensure blank project files can be deleted by github runner

game-ci / unity-builder

Build Unity projects for different platforms

https://github.com/marketplace/actions/unity-builder

MIT License

853 stars 253 forks source link

Ensure blank project files can be deleted by github runner #599

Closed AndrewKahr closed 1 year ago

AndrewKahr commented 1 year ago

Changes

chmod blank project folder to fix host permission errors

Related Issues

https://github.com/game-ci/unity-builder/issues/598

Checklist

[x] Read the contribution guide and accept the code of conduct
[x] Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR in the documentation repo)
[x] Readme (updated or not needed)
[x] Tests (added, updated or not needed)

github-actions[bot] commented 1 year ago

Cat Gif

antoinerrr commented 1 year ago

@AndrewKahr One edge-case tho, since the chmod is done after the build, a job that is canceled will break the next one

AndrewKahr commented 1 year ago

Good catch! I've gone ahead and reworked the Linux scripts to allow running the container as the same user on the host so we don't get these root permission errors anymore on self-hosted.