game-ci / unity-builder

Build Unity projects for different platforms
https://github.com/marketplace/actions/unity-builder
MIT License
852 stars 250 forks source link

Hotfixes for 4.2.0 #630

Closed AndrewKahr closed 9 months ago

AndrewKahr commented 9 months ago

Changes

Checklist

github-actions[bot] commented 9 months ago

Cat Gif

codecov-commenter commented 9 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4ae184c) 36.97% compared to head (d17e484) 36.93%.

:exclamation: Current head d17e484 differs from pull request most recent head b6a5abb. Consider uploading reports for the commit b6a5abb to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/game-ci/unity-builder/pull/630/graphs/tree.svg?width=650&height=150&src=pr&token=eRCPplc2s1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci)](https://app.codecov.io/gh/game-ci/unity-builder/pull/630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci) ```diff @@ Coverage Diff @@ ## main #630 +/- ## ========================================== - Coverage 36.97% 36.93% -0.04% ========================================== Files 77 77 Lines 3116 3119 +3 Branches 605 608 +3 ========================================== Hits 1152 1152 - Misses 1964 1967 +3 ``` | [Files](https://app.codecov.io/gh/game-ci/unity-builder/pull/630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci) | Coverage Δ | | |---|---|---| | [src/model/image-tag.ts](https://app.codecov.io/gh/game-ci/unity-builder/pull/630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci#diff-c3JjL21vZGVsL2ltYWdlLXRhZy50cw==) | `49.45% <28.57%> (-1.69%)` | :arrow_down: |
AndrewKahr commented 9 months ago

Looks good to me 👍 Nice one.

I see there are some jobs failing. Not sure if it's related to current changes or if they're just flaky jobs 🤷

Saving job output here in case job logs expire:

Details

Ah, it looks like switching tests to pure il2cpp was a bit too greedy on tests as Linux can't build Windows il2cpp. I think what I'll do is still merge this PR and get the hotfix out to unbreak people's pipelines then fix the test workflow since that won't impact anyone else using the action.

GabLeRoux commented 9 months ago

Ah, it looks like switching tests to pure il2cpp was a bit too greedy on tests as Linux can't build Windows il2cpp. I think what I'll do is still merge this PR and get the hotfix out to unbreak people's pipelines then fix the test workflow since that won't impact anyone else using the action.

Sounds good 🚀