search

game-ci / unity-builder

Build Unity projects for different platforms
https://github.com/marketplace/actions/unity-builder
MIT License
852 stars 250 forks source link

Unity 2018 and .NET 3.5 support #633

Closed zdickinsonfugro closed 1 month ago

zdickinsonfugro commented 8 months ago

Removed all instances of interpolated strings from editor scripts so we don't get compiler errors on old versions of .NET in Unity 2018

Changes

Related Issues

Related PRs

Successful Workflow Run Link

PRs don't have access to secrets so you will need to provide a link to a successful run of the workflows from your own repo.

Checklist

github-actions[bot] commented 8 months ago

Cat Gif

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.99%. Comparing base (fc0a52b) to head (92e3173).

:exclamation: Current head 92e3173 differs from pull request most recent head bf8ada8. Consider uploading reports for the commit bf8ada8 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/game-ci/unity-builder/pull/633/graphs/tree.svg?width=650&height=150&src=pr&token=eRCPplc2s1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci)](https://app.codecov.io/gh/game-ci/unity-builder/pull/633?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci) ```diff @@ Coverage Diff @@ ## main #633 +/- ## ======================================== Coverage 36.99% 36.99% ======================================== Files 77 77 Lines 3122 3122 Branches 609 645 +36 ======================================== Hits 1155 1155 + Misses 1967 1824 -143 - Partials 0 143 +143 ``` [see 37 files with indirect coverage changes](https://app.codecov.io/gh/game-ci/unity-builder/pull/633/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci)
timcassell commented 8 months ago

Proper fix for #309. 👍

timcassell commented 8 months ago

Probably should add a test to prevent regressions.