game-ci / unity-builder

Build Unity projects for different platforms
https://github.com/marketplace/actions/unity-builder
MIT License
852 stars 250 forks source link

Add 'enableGpu' param, allowing running Unity w/o `-nographics` #636

Closed codenamesimon closed 8 months ago

codenamesimon commented 8 months ago

Changes

Related PRs

Successful Workflow Run Link

Validated inside org repository.

Checklist

github-actions[bot] commented 8 months ago

Cat Gif

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.99%. Comparing base (e820c9c) to head (76ec478).

:exclamation: Current head 76ec478 differs from pull request most recent head e1a2483. Consider uploading reports for the commit e1a2483 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/game-ci/unity-builder/pull/636/graphs/tree.svg?width=650&height=150&src=pr&token=eRCPplc2s1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci)](https://app.codecov.io/gh/game-ci/unity-builder/pull/636?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci) ```diff @@ Coverage Diff @@ ## main #636 +/- ## ========================================== + Coverage 36.93% 36.99% +0.06% ========================================== Files 77 77 Lines 3119 3122 +3 Branches 608 609 +1 ========================================== + Hits 1152 1155 +3 Misses 1967 1967 ``` | [Files](https://app.codecov.io/gh/game-ci/unity-builder/pull/636?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci) | Coverage Δ | | |---|---|---| | [src/model/build-parameters.ts](https://app.codecov.io/gh/game-ci/unity-builder/pull/636?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci#diff-c3JjL21vZGVsL2J1aWxkLXBhcmFtZXRlcnMudHM=) | `90.00% <ø> (ø)` | | | [src/model/image-environment-factory.ts](https://app.codecov.io/gh/game-ci/unity-builder/pull/636?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci#diff-c3JjL21vZGVsL2ltYWdlLWVudmlyb25tZW50LWZhY3RvcnkudHM=) | `4.00% <ø> (ø)` | | | [src/model/input.ts](https://app.codecov.io/gh/game-ci/unity-builder/pull/636?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=game-ci#diff-c3JjL21vZGVsL2lucHV0LnRz) | `88.81% <100.00%> (+0.22%)` | :arrow_up: |
codenamesimon commented 8 months ago

Yes, the command line argument is properly stripped:

Launching external process: /Applications/Unity/Hub/Editor/2021.3.29f1/Unity.app/Contents/Resources/PackageManager/Server/UnityPackageManager

COMMAND LINE ARGUMENTS:
/Applications/Unity/Hub/Editor/2021.3.29f1/Unity.app/Contents/MacOS/Unity
-logFile
-
-quit
-batchmode
-username
***
-password
(hidden)
-customBuildName
appBundle
... etc etc
webbertakken commented 8 months ago

Cool. Will merge it. Would you mind still addressing point 2 from the checklist, please?