Closed AndrewKahr closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 36.97%. Comparing base (
0c16aab
) to head (9b7bf61
).:exclamation: Current head 9b7bf61 differs from pull request most recent head 84b41f7. Consider uploading reports for the commit 84b41f7 to get more accurate results
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Not sure I agree with the reasoning on this one. Just because they add a new version scheme that's actually not so very different doesn't meant we have to make logic more implicit and call it out of scope. In the other PRs, we also still use a regex. The argument "if they change things again" is generally not a great one in software development either.
I'd prefer to keep specific rather than implicit and not architecting for things that might never be.
Changes
Checklist