GabLeRoux
commented
4 months ago Hi, I did not know about this before reading this issue. Here is a Stack Overflow post requesting for Docker registry mirrors
Can you elaborate on why we should implement this?
- Do you have any use case or specific reasons that makes it better?
- Have you encountered problems because of the lack of mirrors so far?
These are honest questions by the way, I am mostly curious to know how having mirrors could benefit the different actions. I suppose that this feature would probably have to reach the different other related github actions too.
Possible Implementation details
In the case where someone would be interested in implementing this, my understanding is that we would have to update these files:
class Input {
// ... existing code ...
static get dockerRegistryMirrors(): string[] {
const input = Input.getInput('dockerRegistryMirrors');
if (!input) {
return [];
}
try {
return yaml.load(input) as string[];
} catch (e) {
core.error(`Failed to parse dockerRegistryMirrors input: ${e}`);
return [];
}
}
// ... existing code ...
}
Somewhere in here: https://github.com/game-ci/unity-builder/blob/461ecf7cea76a46f6a2543d84a7d4f498a91dba2/src/model/docker.ts#L35-L89:
We would have to add something like this:
const registryMirrors = Input.dockerRegistryMirrors.map(mirror => `--registry-mirror=${mirror}`).join(' ');
return `docker run \
${registryMirrors} \
// ...And maybe for the windows based docker run command too?
And then, could be used with something like this in the workflow file:
- name: Build with Docker
run: |
# Your build steps here
with:
dockerRegistryMirrors: |
- https://mirror1.example.com
- https://mirror2.example.comIf this is absolutely necessary, don't forget that you can fork the repository, update the code and try it 👍
JSBmanD
webbertakken
Context
Currently there's no possibility to change list of docker mirrors
Suggested solution
Will be nice to have variable to set list of mirrors for docker