search

game-ci / unity-builder

Build Unity projects for different platforms
https://github.com/marketplace/actions/unity-builder
MIT License
834 stars 237 forks source link

Docker command fails for some unity passwords in Github Actions #657

Open william-dafriend opened 1 month ago

william-dafriend commented 1 month ago

Bug description

When running the github action to build a unity project, the password can be seen in clear text in the debug output. Unlike the other values, it is not obfuscated. The docker command fails with "docker run" requires at least 1 argument, possibly due to the password not being properly escaped.

How to reproduce

Use a password with special characters, such as \

Expected behavior

The password is obfuscated and the command runs.

mfbrantner commented 1 month ago

The docs recommend avoiding special characters in the UNITY_PASSWORD secret.

https://game.ci/docs/github/builder#basic-setup

NOTE: Issues have been observed when using a UNITY_PASSWORD with special characters. It is recommended to use a password without any special characters (mixed-case alphanumeric characters only).