search

game-ci / unity-builder

Build Unity projects for different platforms
https://github.com/marketplace/actions/unity-builder
MIT License
852 stars 250 forks source link

Support UPM private registry on windows runner. #665

Closed Shaun-Fong closed 2 months ago

Shaun-Fong commented 2 months ago

Changes

Related Issues

Successful Workflow Run Link

PRs don't have access to secrets so you will need to provide a link to a successful run of the workflows from your own repo.

Checklist

github-actions[bot] commented 2 months ago

Cat Gif

coderabbitai[bot] commented 2 months ago

[!IMPORTANT]

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (1) * `dist/platforms/windows/build.ps1` is excluded by `!**/dist/**`

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough ## Walkthrough The changes introduce new configuration options for handling package management and registry access. Specifically, an optional input parameter `scopedRegistryUrl` is added to `action.yml`, along with new properties in the `BuildParameters` class and environment variables in the `ImageEnvironmentFactory` and `SetupMac` classes. Additionally, static getter methods for these parameters are introduced in the `Input` class. These modifications enhance the flexibility and configurability of the system. ## Changes | Files | Change Summary | |-----------------------------------------------|--------------------------------------------------------------------------------------------------------| | `action.yml` | Added new optional input parameter `scopedRegistryUrl` for package dependency resolution. | | `src/model/build-parameters.ts` | Introduced `scopedRegistryUrl` and `upmRegistryToken` properties to the `BuildParameters` class. | | `src/model/image-environment-factory.ts` | Added environment variables `SCOPED_REGISTRY_URL` and `PRIVATE_REGISTRY_TOKEN` for registry access. | | `src/model/input.ts` | Introduced static getters for `scopedRegistryUrl` and `upmRegistryToken` to retrieve input values. | | `src/model/platform-setup/setup-mac.ts` | Set new environment variables `PRIVATE_REGISTRY_TOKEN` and `SCOPED_REGISTRY_URL` based on `buildParameters`. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant User participant Action participant BuildParameters participant ImageEnvironmentFactory participant SetupMac User->>Action: Provide scopedRegistryUrl Action->>BuildParameters: Set scopedRegistryUrl BuildParameters->>ImageEnvironmentFactory: Pass scopedRegistryUrl ImageEnvironmentFactory->>SetupMac: Set SCOPED_REGISTRY_URL SetupMac->>ImageEnvironmentFactory: Use SCOPED_REGISTRY_URL for setup ``` ## Poem > 🐇 In fields of code, I hop with glee, > New paths for packages, oh what a spree! > Scoped URLs and tokens, a grand delight, > In the world of builds, everything feels right! > With every change, we dance and play, > Celebrating progress, hip-hip-hooray! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 2 months ago

Cat Gif