game-ci / unity-orb

Build and test Unity projects for several platforms using CircleCI.
https://circleci.com/developer/orbs/orb/game-ci/unity
MIT License
7 stars 12 forks source link

feat: replace `docker cp` with a mounted volume in `build` #47

Closed EricRibeiro closed 1 year ago

EricRibeiro commented 1 year ago

Changes

This PR adds support for Windows Hyper-V containers by replacing docker cp with a mounted volume. At the moment, if a user runs the build command on a Hyper-V container, they will receive the following message:

Error response from daemon: filesystem operations against a running Hyper-V container are not supported

With this change, a build folder is created inside the working directory and mounted in the Windows container. While this solves the issue above, it may result in leftover artifacts in non-ephemeral environments if the runner agent is not set to clean up the working directory. Alternatively, users can clean the directory themselves before the end of the workflow.

Checklist

mishkaechoes commented 1 year ago

Thank you for these changes