search

game-ci / unity-orb

Build and test Unity projects for several platforms using CircleCI.
https://circleci.com/developer/orbs/orb/game-ci/unity
MIT License
8 stars 11 forks source link

Fix macOS Executors #72

Closed GabLeRoux closed 3 months ago

GabLeRoux commented 3 months ago

Closes https://github.com/game-ci/unity-orb/issues/71

GabLeRoux commented 3 months ago

Job was rejected because resource class large, image xcode:15.3.0 is not a valid resource class

🤔

thedrhax14 commented 3 months ago

On top of that it is unable to activate unity license (here at line 33)

GabLeRoux commented 3 months ago

Indeed, license activation that is failing is likely due to changes from Unity. I wrote a fix for gitlab-ci a while back (which omg I should definitely merge, I'll find some time this summer to clean things up).

We're basically activating by extracting a serial out of a free license file.

GabLeRoux commented 3 months ago

I'm not actively using this orb, but if anyone would like to help me bring this back up and running, don't hesitate to ping me and I'll create a release once we get the activation working again 🙏

GabLeRoux commented 3 months ago

I managed to get the macOs jobs to run again by using macos.m1.medium.gen1, but now they're failing with activation. I would say it is now better than it used to be. All we need is to fix the activation steps which we can inspire by what was done in here.

More precisely in before_script.sh

thedrhax14 commented 3 months ago

I managed to get the macOs jobs to run again by using macos.m1.medium.gen1, but now they're failing with activation. I would say it is now better than it used to be. All we need is to fix the activation steps which we can inspire by what was done in here

(1) Does it mean an actual license (at least personal license) should be used? (2) As far as I understood anyone who has the environment variables for unity license set in their circleci account then the pipeline should work, right? (3) Or is it still necessarily to update the sh scripts as well?

GabLeRoux commented 3 months ago

(1) Does it mean an actual license (at least personal license) should be used?

I think there's already one configured for the current repository in CircleCI's side. Or it used to. On Github side, we set these env vars for the github actions to properly test the actions:

(2) As far as I understood anyone who has the environment variables for unity license set in their circleci account then the pipeline should work, right?

I'm not a 100% sure. This would be preferable indeed, but we're facing the activation issues with the version 3.x.x of the Docker images which might be a breaking change for activation so I wouldn't count too much on it.

To do this the right way, we should keep fixing things and then decide if we release 1.8.0 or 2.0.0 for this orb. The only way we can confirm this would be to have an already working project with orb running on 1.7.0 and then try the pipelines again with updated codebase (once we fix the activation scripts in current repo).

(3) Or is it still necessarily to update the sh scripts as well?

I think so.

GabLeRoux commented 3 months ago

I'll merge this in main branch as well (main branch is already unstable and wasn't up to date with latest Unity versions anyway).

At least we're using updated macOS Executors in here now 🚀

Let's figure out the best way to solve activation for this orb and bring it back to life :)

thedrhax14 commented 3 months ago

I think there's already one configured for the current repository in CircleCI's side. Or it used to. On Github side,

My only suspicion after inspecting last pipeline is that current UNITY_LICENSE or UNITY_SERIAL is either revoked or expired. I hope I was looking at a right part of it

GabLeRoux commented 3 months ago

I think there's already one configured for the current repository in CircleCI's side. Or it used to. On Github side,

My only suspicion after inspecting last pipeline is that current UNITY_LICENSE or UNITY_SERIAL is either revoked or expired. I hope I was looking at a right part of it

That sounds right, I'll see if I have access to the settings and fill some of them again. edit1: I currently don't have access to the secrets. I'll try to reach original authors or CircleCI and see what we can do 🙏 edit2: I had to re-authorize my github link in CircleCI and I now have access to the org, I'll be able to update the secrets if needed.

GabLeRoux commented 3 months ago

I've created two followup issues:

I'll ping some people around to see if they can help.