game-ci / unity-orb

Build and test Unity projects for several platforms using CircleCI.
https://circleci.com/developer/orbs/orb/game-ci/unity
MIT License
7 stars 12 forks source link

unity-orb: android support #9

Closed mrothstein74 closed 2 years ago

KyleTryon commented 2 years ago

Thank you @mrothstein74!

It looks like the build was successful but I wanted to point out that I noticed some memory warnings. Not surprising given how much memory android uses.

image

https://app.circleci.com/pipelines/github/mrothstein74/unity-orb/9/workflows/e4bfce70-f70f-4cb9-83e6-c2325acadea7/jobs/75/resources

We may be fine with our tests, and I think it is a good idea to keep the test as cheap as possible for the sake of the credits used by game-ci, but for end-users we may want to suggest using, at minimum, the "large" resource class.

I think we might want to add a usage example to this PR, but I want to tag @EricRibeiro to discuss how that should look right now.

EricRibeiro commented 2 years ago

Closing as this will be included in #11 along with other platforms.