search

game-ci / unity-test-runner

Run tests for any Unity project
https://github.com/marketplace/actions/unity-test-runner
MIT License
206 stars 135 forks source link

v4.1.0 causing activation to fail when using manual offline activation #253

Closed poi-vrc closed 8 months ago

poi-vrc commented 8 months ago

Bug description

I was previously using game-ci/unity-test-runner@v4 on my builds. And activated Unity personal edition in GitHub Actions using the manual activation method for months: https://github.com/game-ci/documentation/issues/408

How to reproduce

Activate using manual activation and paste the ulf content as a secret in UNITY_LICENSE. Use game-ci/unity-test-runner@v4 in the workflow file, which will resolve to v4.1.0 and run a build. The activation will fail. image

Successfully activate, build and test.

Additional details

Reverting to v4.0.0 by using game-ci/unity-test-runner@v4.0.0 can activate successfully.

AndrewKahr commented 8 months ago

Did you pass in UNITY_EMAIL and UNITY_PASSWORD in addition to the license?

poi-vrc commented 8 months ago

No, I did not pass those secrets. It was working without the email and password previously. Are they required since v4.1.0?

AndrewKahr commented 8 months ago

Indeed it is now required. It was actually supposed to be required since v4.0.0 but the code didn't align with Unity-Builder properly. I will update the release notes to make that more clear

AndrewKahr commented 8 months ago

I should also note it needs to be the same credentials as the account used to activate the license.

Apologies for the inconvenience!

poi-vrc commented 8 months ago

Thanks. I will modify my workflows later on.