BUG: Original NFT data is modified after IBC transfers

[giansalex]

Summary

The NFT data is modified when it is sent to chains with nft-transfer module, but not when it is sent to CosmWasm chains (cw-ics721).

Environment

• OS: Ubuntu 20.04.4
• Software version: iris@1.4.1-gon-testnet

Steps to Reproduce

• Create collection, mint an NFT on IRIS

• Transfer to JUNO / Return to IRIS (data is not modified) NFT data:

  {"irismod:name":{"value":"GoN NFT 001"},"irismod:uri_hash":{"value":""}}

• Transfer to Uptick / Return to IRIS NFT data:

  {"irismod:name":{"value":"GoN NFT 001"},"irismod:uri_hash":{"value":""},"uptickd:name":{"value":""},"uptickd:uri_hash":{"value":""}}

• Transfer to Omniflix / Return to IRIS NFT data:

  {"irismod:name":{"value":"GoN NFT 001"},"irismod:uri_hash":{"value":""},"omniflix:created_at":{"value":"0001-01-01T00:00:00Z"},"omniflix:description":{"value":""},"omniflix:extensible":{"value":true},"omniflix:name":{"value":""},"omniflix:nsfw":{"value":false},"omniflix:preview_uri":{"value":""},"omniflix:royalty_share":{"value":"0.000000000000000000"},"omniflix:transferable":{"value":true},"omniflix:uri_hash":{"value":""},"uptickd:name":{"value":""},"uptickd:uri_hash":{"value":""}}

Expected and Actual Behavior

I would expect that the NFT data will not be modified, or that the behavior will be the same in all ICS721 implementations.

Additional Context

[giansalex]

Another case: NFT not updatable, can be modified via ICS721

An NFT from a collection created with --update-restricted=true, cannot be modified, if you try to edit (iris tx nft edit), you receive the error message:

failed to execute message; message index: 0: nobody can update the NFT under this denom disperze02: unauthorized

but if you transfer to custom remote chain, you can return new data, and modify the original NFT.

[dreamer-zq]

Another case: NFT not updatable, can be modified using ICS721

An NFT from a collection created with --update-restricted=true, cannot be modified, if you try to edit (iris tx nft edit), you receive the error message:

failed to execute message; message index: 0: nobody can update the NFT under this denom disperze02: unauthorized

but if you transfer to custom remote chain, you can return new data, and modify the original NFT.

First of all many thanks, this issue is known.

1. For the ics721 protocol, it does not stipulate whether the data of nft can be modified, which depends on the application layer implemented.
2. From the perspective of iris, --update-restricted=true, it is true that the data of nft should not be modified. At that time, only things at the ics721 protocol level were considered. Therefore, in the subsequent release of the main network, this should be implement.