game1n / t8-cms

[WIP] A micro content management system
t8-cms.vercel.app
MIT License
8 stars 8 forks source link

#5 eslint and prettier setup #8

Closed eLeontev closed 2 years ago

eLeontev commented 2 years ago

Issue: #5

Changes:

kishankr7979 commented 2 years ago

@eLeontev Please use husky and add a pre-commit file. Eslint should auto run whenever anyone try to commit the code via git.

ps-89 commented 2 years ago

@eLeontev Can you also please check which new dependency under the hood uses the vulnerable package( @humanwhocodes/config-array@0.10.7), and if we can upgrade that dependency to the latest version(if possible)?

Dependency analysis present at https://github.com/game1n/t8-cms/actions/runs/3164895830/jobs/5153533428

ps-89 commented 2 years ago

@eLeontev We can squash all commits into one (or keep separate commits if there's a need for that), having 2 commits with the same message is a bit confusing at a later point in time when going through the git history.

How to squash last N commits - https://www.internalpointers.com/post/squash-commits-into-one-git

If this is something you don't know yet or find difficult, you can skip this, but this is quite helpful to learn.

eLeontev commented 2 years ago

@eLeontev Can you also please check which new dependency under the hood uses the vulnerable package( @humanwhocodes/config-array@0.10.7), and if we can upgrade that dependency to the latest version(if possible)?

Dependency analysis present at https://github.com/game1n/t8-cms/actions/runs/3164895830/jobs/5153533428

I guess it's out of the MR, I just removed package-lock.json since it was not used in the project before. btw the audit system highlights that it's issue from react-scripts package and cannot be fixed until this package not updated yet.

Screenshot 2022-10-01 at 16 36 42
eLeontev commented 2 years ago

@eLeontev We can squash all commits into one (or keep separate commits if there's a need for that), having 2 commits with the same message is a bit confusing at a later point in time when going through the git history.

How to squash last N commits - https://www.internalpointers.com/post/squash-commits-into-one-git

If this is something you don't know yet or find difficult, you can skip this, but this is quite helpful to learn.

usually it's up to a repo owners to set it up on PR merge, btw I squashed the commits

ps-89 commented 2 years ago

@eLeontev Yes, we can squash while merging too, though if someone prefers to merge branches to the main branch via terminal, having a single commit with all the changes or having multiple commits with good messages helps.

Thanks a lot for your contribution, and welcome again to the project. I'm approving the PR and will wait for @kishankr7979 for any other comments and final approval. Looking forward to more contributions from you, as we've just started working on the project, so there'll be some good tasks that'll come up. Cheers!