gameblabla / sms_sdl

Improved port of SMSPlus-GX for the RS-97
11 stars 15 forks source link

Optimization 01-03 causes core to crash #12

Closed negativeExponent closed 2 years ago

negativeExponent commented 2 years ago

by default, libretro port uses optimization as much as possible. This cause the core to crash in some cases. I have observed this when playing Bonkers Wax Up! (Brazil) as soon as you select Play

backtrace (https://gist.github.com/negativeExponent/10c271cfa044ebc837c8e26049e4df84) Seems like a case of buffer overflow since it tries to read memory past 0xffff;

gameblabla commented 2 years ago

Maybe it's trying to draw outside the framebuffer ? I thought i had fixed that... Well i hope it's that issue and not something else :P

negativeExponent commented 2 years ago

thanks for the reply. ignoring memory reads past 0xffff fixes it, but im not familiar with the system behavior. its definetely wrong though trying to read outside of max memory.

it crashes on GCC 11.1.0, clang 13.0.0 does not seem to care and just runs the app fine