search

gamecreature / QtAwesome

QtAwesome - Font Awesome for Qt Applications
Other
773 stars 147 forks source link

Add CMake compatibility #43

Closed MartinDelille closed 1 year ago

MartinDelille commented 1 year ago

I'm thinking about moving from qmake to cmake and I'll wondered if you would accept this small addition to make it compatible ?

gamecreature commented 1 year ago

Hi @MartinDelille, Thank you for you contribution. I'm comparing this with the previous pull request which has been waiting for ages. This on doesn't change the headers, so that a plus :-) I see it depends on Qt5, is possible to change it so it allows other versions?

Could you explain how to use it with CMake in readme.md?

Jihadist commented 1 year ago

@MartinDelille ping :)

MartinDelille commented 1 year ago

Sorry I didn't saw the first notification! I will try to update it to support Qt5 and Qt6. Would it be fine for you ? I don't know if Qt4 is needed.

gamecreature commented 1 year ago

@MartinDelille, no problem. I didn't test Qt4 with latest release, so you can leave that one out. (Qt4 support is in the other branches). Thanks for your time!

MartinDelille commented 1 year ago

I fixed qt6 compatibility. Unfortunately it doesn't work on Qt6 due to some deprecated function (but maybe it is due to the fact that I am to strong with my warning error).

MartinDelille commented 1 year ago

@Jihadist I asked the cmake channel on https://cpplang.slack.com to review and they advice me the latest commit.

MartinDelille commented 1 year ago

I added an unrelated fix here: a0ad43a

Let me know if you prefer a separate PR for it!

Jihadist commented 1 year ago

It works well with Qt5 and Qt6, thanx :)

gamecreature commented 1 year ago

@Jihadist, @MartinDelille, thanks for contributing!