create dao: values get overwritten on wallet change and cancel tx, should not

gamedaoco / gamedao-beta

https://beta.gamedao.co

Apache License 2.0

9 stars 1 forks source link

create dao: values get overwritten on wallet change and cancel tx, should not #217

Closed soundyogi closed 2 years ago

soundyogi commented 2 years ago

a refresh is triggered that initializes the values in the forms- this needs branching probably

5-mark commented 2 years ago

I fear this ticket was misunderstood due to lack of specification. The implementation now keeps all inputs in all fields even after reload of the page and after switching wallet address or logout and re-login. I would have understood this ticket as such that entered form values just dont get overwritten when switching wallet address or canceling trx - but that doesnt mean we have to keep all entered values forever.

Lets discuss this ticket, so I can write proper ACs. (@soundyogi, @2075)

soundyogi commented 2 years ago

well it is a usecase ( I created a ton of campaigns and when you write long markdown it SUCKS when its all gone so I used external txt files now I dont have to.)

so the form should always be initialized on reload or what is the desired behavior?

soundyogi commented 2 years ago

also I want to change wallets to copy my 2 needed addresses for the treasury and controller for example. this is useful.

we could delete the cached data when a campaign has been created sucessfully, this way when you create a new one its empty and you dont loose state until then

2075 commented 2 years ago

data can be cached until the campaign was created
if you desire to copy/edit the data, this should be done by loading data from ipfs and writing it back (needs to maintain the cid or needs to be updated in a transaction for the e.g. campaign. )
same process also for org and voting

soundyogi commented 2 years ago

k, I will delete the localStorage data when the TX clears the next step is the edit pages then, which is another ticket itself