search

gamedaoco / gamedao-beta

https://beta.gamedao.co
Apache License 2.0
9 stars 1 forks source link

Create DAO : Convert all addresses to current network format #236

Closed cryply closed 2 years ago

cryply commented 2 years ago

Describe the bug While Creating DAO autofilled with KUSAMA address of current polka account it not obvious that we must provide Treasury address also in that format.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://beta.gamedao.co/app/organisations
  2. Click on New DAO
  3. Scroll down to Treasury address
  4. Try to figure out what to enter there.

Expected behavior We must provide info on which chain we operate. We must validate address and give a tip if address in wrong format.

Screenshots image

2075 commented 2 years ago

it is incorrect, actually we accept all network formats, the validation is just broken @soundyogi

cryply commented 2 years ago

So do u accept mixed networks addresses?

soundyogi commented 2 years ago

im on it

https://github.com/polkadot-js/common/blob/master/packages/util-crypto/src/address/check.ts