gamedaoco / gamedao-beta

https://beta.gamedao.co

Apache License 2.0

9 stars 1 forks source link

fix: orga account zero addr validator #274

Closed soundyogi closed 2 years ago

soundyogi commented 2 years ago

Description

The Form Address Validator is broken.

Closes #272

Type of change

[ ] toZeroAddress() in validator to check address

Test:

[ ] Paste Addresses for Treasury and Controller

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/75/gamedao-beta/QGXCx6dqCpvEvUQ6yHNQ6D7cYztu
✅ Preview: https://gamedao-beta-git-sy-fixorgacreateaddrvalidator-75.vercel.app

2075 commented 2 years ago

frontend apes when sending a create dao tx

soundyogi commented 2 years ago

getting nonce too low messages now too....

soundyogi commented 2 years ago

But this is unrelated to the PR I think? Address Format checking seems to work for me now.

2075 commented 2 years ago

hm, cant test unless i roll back the previous merge... will merge for now but without fixing the tx the frontend cannot be used.

2075 commented 2 years ago

btw, do you validate if the address is a substrate compatible address or if it is zero network specific?

soundyogi commented 2 years ago

I use the toZeroAddress() Andre created - And I believe it checks for our network prefix.