DAO membership fee transfer is not transferred but reserved

[5-mark]

Describe the bug Creating a DAO with the setting "Fee Model = transfer" does reserve the fee on the joiners wallet when joining but should transfer the fee to the DAO treasury.

To Reproduce Steps to reproduce the behavior:

1. Create a DAO with setting "Fee Model = transfer" and enter a number (eg. 1)
2. choose another wallet than controller or treasury wallet and check your balances
3. check the balances of the DAO treasury ( and the controller - just to be sure)
4. Join the DAO with that wallet
5. See that the fee is "reserved" in your wallet and not transferred to the DAO treasury

Expected behavior When selecting fee model "transfer" the DAO treasury should get the fee from the user.

Screenshots

Additional context

[2075]

possibly the values are mixed up:

            match &config.fee_model {
                ControlFeeModel::NoFees => {
                },
                ControlFeeModel::Reserve => {
                    <balances::Module<T>>::reserve(&account, config.fee)?;
                },
                ControlFeeModel::Transfer => {
                    let treasury = BodyTreasury::<T>::get(hash);
                    let transfer = <balances::Module<T> as Currency<_>>::transfer(
                        &account,
                        &treasury,
                        config.fee,
                        ExistenceRequirement::AllowDeath
                    );
                },
                _ => {}
            }

can you try what happens, when you select reserve?

[2075]

@5-mark ah found the bug, updated the dropdown provider:

export const dao_fee_model = [
    { key: '0', text: 'no fees', value: 0 }, // fees are reserved in actor account
    { key: '1', text: 'reserve', value: 1 }, // fees are paid to treasury
    { key: '2', text: 'transfer', value: 2 }, // fees are staked and may result in item drops
]

fixed in main: please try again in 10mins.

[5-mark]

@2075 just tried again. but still same behaviour. Setting transfer as fee model but seeing the fee reserved. How comes this bug was fixed? it is still in the buglog and not in review. Also I didnt see any pull request?

[2075]

i just updated the three values in the main branch. if you can see the three values as shown above, the correct fee calculation should apply.

[2075]

please verify @5-mark @soundyogi

[soundyogi]

testing.

[2075]

@soundyogi

[2075]

@5-mark

[2075]

testing.

any results @soundyogi ?

[soundyogi]

• [x] Create a DAO with setting "Fee Model = transfer" and enter a number (eg. 1)
• [x] choose another wallet than controller or treasury wallet and check your balances
• [x] check the balances of the DAO treasury ( and the controller - just to be sure)

• [x] Join the DAO with that wallet

- [] See that the fee is "reserved" in your wallet and not transferred to the DAO treasury

[soundyogi]

So it seems to me behavior works as intended.

• [x] Fee gets deducted from "Check" account on joining the DAO.
• [x] Fee gets send to treasury. Closing.

[soundyogi]

for good measure, the same for reserved variant:

• [x] create a DAO with reserve model and fee of 1

• [x] join organisations using the check account:

now all 3 accounts show 1 token reserved:

[soundyogi]

@2075 @5-mark is this reserve behavior correct?

[2075]

should:

0 = no fees 1 = reserve, no transfer 2 = transfer to treasury

[soundyogi]

for some reason on all 3 accounts (controller, trasury, newMember) 1 ZERO was reserved - this is what seems odd to me

[2075]

hm reserved or maybe tx fees?

[2075]

lets move to discord

[soundyogi]

I can confirm that 1 ZERO gets reserved for each the treasury and the controller when creating a organisations with the reserve fee model.