search

gamedev-pro / dmotion

DMotion - A high level Animation Framework for Unity DOTS
Other
491 stars 47 forks source link

AnimationParameterAsset Hash Fixes #18

Closed TitomakaniJr closed 2 years ago

TitomakaniJr commented 2 years ago
TitomakaniJr commented 2 years ago

I mentioned another issue in my post on the Unity Forums, however I did not include it in this PR.

The error in editor is as follows: The system DMotion.ClipSamplingSystem reads DMotion.ClipSampler via SampleRootDeltasJob but that type was not assigned to the Dependency property. To ensure correct behavior of other systems, the job or a dependency must be assigned to the Dependency property before returning from the OnUpdate method.

However, both jobs are using DynamicBuffer<ClipSampler > as ReadOnly. The difference is one uses a BufferFromEntity and the other passes it in on the IJobEntity.

So while JobsDebugger complains there are no actual issues with the two jobs running in parallel, and adding the unneeded dependency could have performance implications. Seems to be a bug on Unity's side.

gabrieldechichi commented 2 years ago

Hi @TitomakaniJr, thanks for this PR! I merged your changes manually to v0.3.3 as it had conflicts with StateMachineParameterUtils, after changes I made for this release.