bug: Red Orchestra and Red Orchestra: Ostfront 41-45 should be the same game

[dgibbs64]

Describe the bug I just noticed that there is both "Red Orchestra" and "Red Orchestra: Ostfront 41-45" listed however I believe these are the same game. I can also confirm that Red Orchestra: Ostfront 41-45 does not use gamespy1 but uses both unreal2 and valve queries (just like Killing Floor 1). I don't believe there was a game simply called Red Orchestra. So IMO this looks like an error and they should be merged. https://github.com/gamedig/node-gamedig/blob/master/lib/games.js#L2358 https://store.steampowered.com/app/1200/Red_Orchestra_Ostfront_4145

  roo4145: {
    name: 'Red Orchestra: Ostfront 41-45',
    release_year: 2006,
    options: {
      port: 7757,
      port_query_offset: 10,
      protocol: 'unreal2'
    },
    extra: {
      old_id: 'redorchestraost'
    }
  },

[dgibbs64]

I have found reference to a game called "Red Orchestra: Combined Arms" which was the original mod

[CosminPerRam]

The entry (before removing replacing games.txt) was added in this mega commit, I'll too look into it a bit to confirm everything you mentioned (which is really helpful, thanks bunch) and that the PR is a proper fix.

[CosminPerRam]

I queried this on master by: node .\bin\gamedig.js --type roo4145 142.132.192.19:7757 and I got an expected response. Also using protocol-unreal2 with an offset of +1 worked, but no valve response.

But this one did not respond to gamespy1 (and valve) but did on unreal2 (again with +1).

[CosminPerRam]

redorchestra: {
    name: 'Red Orchestra',
    release_year: 2018,
    options: {
      port: 7758,
      port_query_offset: 1,
      protocol: 'unreal2'
    }
  }

The release year of this entry was added in this commit, which seems to be completely wrong as I cannot find any released game with Red Orchestra in the name from 2018.

Considering it uses the unreal2 protocol (and that in my previous commit servers responds to it), I think this entry was added as an alternative query method, not necessarily as being another game (unless it was referenced to (as you mentioned) "Red Orchestra: Combined Arms").