gamedig / node-gamedig

Query game servers and not only! Node.JS/Deno/Bun or Bash (via the CLI).
https://www.npmjs.com/package/gamedig
MIT License
608 stars 146 forks source link

bug: Starbound returns incorrect appid #617

Open dgibbs64 opened 2 months ago

dgibbs64 commented 2 months ago

Describe the bug For some reason Starbound returns the appid 65534 instead of its actual appid 211820. I don't know if this is a bug in gamedig or the query itself is an issue.

Steps To Reproduce Query a starboudn server and check the apid

Expected behavior The appid should be that of Starbound 211820

CosminPerRam commented 2 months ago

Hmm, Starbound uses the vanilla Valve protocol and Gamedig does not alter the appid at all. Indeed 211820 is Starbound and 65534 is an unknown id.

Some games have different app ids if they run as dedicated servers but it seems this isn't the case here, so what it might happened is:

So, overall I do not think this is a GameDig issue, but I'll search around more to see if there are any other instances of this happening with Starbound.

dgibbs64 commented 2 months ago

Might be a mistake on the Starbound Dev's part, but since Starbound hasn't been updated in a long time I doubt it will get fixed. I might have to correct it manually in my code