gamedig / rust-gamedig

Game Server Query Library.
https://crates.io/crates/gamedig
MIT License
35 stars 10 forks source link

Bad ID tests #184

Open Douile opened 5 months ago

Douile commented 5 months ago

Over on node the ID tests have encountered a few bugs: https://github.com/gamedig/node-gamedig/pull/496

Bugs are as follows

IDFail {
    game_id: "cs2d",
    game_name: "CS2D",
    expected_id: "c2d",
    rule_stack: [
        NumbersAreTheirOwnWord,
        MoreThanTwoWordsMakeAcronym,
    ],
}

Halo Online (ElDewrito) instead of Halo Online - ElDewrito.

IDFail {
    game_id: "eldewrito",
    game_name: "Halo Online ",
    expected_id: "haloonline",
    rule_stack: [
        TwoWordsOrLessUseFullWords,
    ],
}

There are also some IDs that would require rule changes to match how node currently has them:

podrivo commented 5 months ago

Just fixed Halo Online - ElDewrito. Thanks for pointing it out! (: