gamedig / rust-gamedig

Game Server Query Library.
https://crates.io/crates/gamedig
MIT License
35 stars 10 forks source link

chore: apply clippy suggestions #208

Closed CosminPerRam closed 1 week ago

CosminPerRam commented 2 weeks ago

Applied assigning_clones which could help performance. Andredundant_static_lifetimes which just cleans up obvious a lifetime.

I also have sorted out some unused imports warnings, see below comment.

CosminPerRam commented 2 weeks ago
warning: unused import: `protocol::*`                                                                                                                                                                                      
 --> crates\lib\src\games\minecraft\mod.rs:7:9
  |
7 | pub use protocol::*;
  |         ^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: unused import: `query::*`                                                                                                                                                                                         
  --> crates\lib\src\lib.rs:59:9
   |
59 | pub use query::*;
   |         ^^^^^^^^

We need these for easier user use, so I just #[allow(unused_import)].


warning: unused import: `crate::protocols::epic::Credentials`
  --> crates\lib\src\games\definitions.rs:12:5
   |
12 | use crate::protocols::epic::Credentials;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

We didn't used this anywhere in that scope, so I removed it.