search

gamedig / rust-gamedig

Game Server Query Library.
https://crates.io/crates/gamedig
MIT License
38 stars 11 forks source link

Numeric fields standardization problem. #51

Closed CosminPerRam closed 1 year ago

CosminPerRam commented 1 year ago

As reminded in #48, multiple common numeric fields (such as players_maximum and players_online) are using different types (usize for the GameSpy protocols, u32 for Minecraft ones and so on...), we should decide on a standard type for all numeric types.

CosminPerRam commented 1 year ago

players score: It seems that the most appropriate one would be i32, as some games can report negative numbers for these. players_maximum/players_online/players_minimum: Any higher unsigned integer should be good, I'd go with u32 as u16 is possibly not enough?