search

gamedig / rust-gamedig

Game Server Query Library.
https://crates.io/crates/gamedig
MIT License
38 stars 11 forks source link

Refactor: Buffer #62

Closed cainthebest closed 1 year ago

cainthebest commented 1 year ago

Ref: #27 Fix's: #26

CosminPerRam commented 1 year ago

This is a very impressive rework! After a glance it looks like this is ready to replace the old bufferer, whats your thoughts on this? If there isn't much to say I could start working on it (as we discussed over the Discord server that I could make the transition).

cainthebest commented 1 year ago

Yeah it looks good to me as far as i have looked, Im happy to handover the PR to you

cainthebest commented 1 year ago

@CosminPerRam 1 thing though, do we keep with bufferer.rs or rename to buffer.rs. Its only internally used

CosminPerRam commented 1 year ago

We could rename it to buffer.

cainthebest commented 1 year ago

ngl this is going to need some more work than expected due to some functions take ownership of the buffer, causing it to go out of scope and be dropped, while a reference to the buffer's data is still needed within the current function's scope.