gamedig / rust-gamedig

Game Server Query Library.
https://crates.io/crates/gamedig
MIT License
38 stars 11 forks source link

Standardize fields #84

Closed CosminPerRam closed 1 year ago

CosminPerRam commented 1 year ago

This PR does something that isn't necessarily needed (the field renaming part), but simplifies fields and makes sure there aren't any problems converting types to the generic variant.

The field renaming also brings a lot of breaking changes, but as discussed over the Discord channel, this release will prioritize many technical changes and the library is still declared to have frequent API breaking changes.

An example of what this PR does is (very small and crude example): The field that represents the amount of players online is: Valve Protocol: players_maximum of u8 The Ship (proprietary Valve Protocol based): max_players of u8 Game Spy (1,2,3): players_maximum of usize.

This PR also closes #51 as this would be something that needs to be addressed here.