search

gamedig / rust-gamedig

Game Server Query Library.
https://crates.io/crates/gamedig
MIT License
38 stars 11 forks source link

[Valve] Add option to disable strict game id #85

Closed Douile closed 1 year ago

Douile commented 1 year ago

What is this feature about? The valve protocol contains code to check if the returned app ID from the server is what is expected given the queried game, if it doesn't match it fails the request with an error. It would be nice to have the option to disable this check (e.g. with GatherSettings) as that was the behavior implemented by node-gamedig.

(Disabling his could cause issues for games built on top of valve protocol that do extra parsing like theship)

Additional context/references

Check code: https://github.com/gamedig/rust-gamedig/blob/65c56dc1960c9f0ba91229a5e24911bd0e38995e/src/protocols/valve/protocol.rs#L441-L455

CosminPerRam commented 1 year ago

Thanks for pointing this out!

[...] It would be nice to have the option to disable this check (e.g. with GatherSettings) as that was the behavior implemented by node-gamedig.

And exactly that has been done here, this app id check is on by default. Feel free to reopen this if needed.