gamefreedomgit / Frostmourne

3 stars 1 forks source link

Debuff Stacking #1228

Closed haephaistoss closed 3 months ago

haephaistoss commented 3 months ago

Description: Snare effects shouldn't stack. Currently, they do, even from the same caster.

How to reproduce: Cast any snare on any target that already has one active

How it should work: "Snare debuffs do not stack. Instead, the debuff that gives the most movement speed reduction takes precedence. If any lesser snare is applied while a greater snare is active, it will not be applied, even if the greater snare will expire sooner."

Database links: https://warcraft.wiki.gg/index.php?title=Snare&oldid=1514399

TEST RESULTS FROM TBCC Blizz:

EQUALLY POTENT SLOWS OVERWRITE each other ONLY if the NEWLY APPLIED ONE'S DURATION is LONGER than the PREVIOUS ONE'S. PREVENT each other from being applied otherwise.

DETAILS:

MAGE:

Forstbolt slow is the weakest, overwrites nothing, prevents nothing.

CAST - SLOWS: Player has control over these:

CONE OF COLD (60%) : Overwrites Frostbolt (50%), prevents it from being applied. Doesn't overwrite Arcane Talent Slow (50%), but prevents it from being applied, giving an error message: 'A more powerful spell is already applied'. Overwrites Blizzard Talent 1/3 (40%), and 2/3 (60%).

BLIZZARD TALENT 2/3 (60%): Overwrites Frostbolt (50%), prevents it from being applied, doesn't overwrite SLOW (50%), but prevents it from being applied. Overwrites Cone of Cold (60%) only if its duration is less than the full duration of the BLIZZARD SLOW (60%).

BLIZZARD TALENT 3/3 (75%): Overwrites Frostbolt (50%), Cone of Cold (60%), prevents them from being applied. Doesn't overwrite Arcane Talent SLOW (50%), but prevents it from being applied.

SLOW (Arcane Talent) (50%): Overwrites Frostbolt Slow 50%, and prevents it from being applied, UNLESS THE NEWLY APPLIED FROSTBOLT SLOW'S DURATION IS LONGER THAN THE REMAINING DURATION OF 'SLOW'..

RANDOM PROC: Player has no control:

ICE / FROST ARMOR: Doesn't overwrite anything, doesn't prevent anything from being applied. (Random Proc Category).

WARRIOR:

HAMSTRING (50%): Overwrites Piercing Howl (50%), prevents it from being applied.

Piercing Howl (50%): Overwrites hamstring only if it's remaining duration is less than that of a newly applied piearing howl, doesn't prevent anything.

Shield Bash (50%): Doesn't overwrite anything, doesn't prevent anything.

SHAMAN:

Frostbrand Weapon (25%): Doesn't overwrite anything, doesn't prevent anything.

FROST SHOCK (50%): Overwrites Frostbrand Weapon, and Earthbrind Totem, prevents Frostbrand Wep from being applied.

EARTHBIND TOTEM (50%): Overwrites Frostbrand Wep, and prevents it from being applied. Overwrites Frostshock only if its duration is shorter than the full duration of the newly applied earthbind totem slow. (Same Potency)

Hunter:

Nothing overwrites anything, pointless to list.

ROGUE:

CRIPPLING POISON (70%): Overwrites and prevents Deadly Throw.

Deadly Throw (50%):

haephaistoss commented 3 months ago

Same applies for stuns, incapacitates etc...

If a more powerful effect is present ie. longer HoJ, Kidney etc, a new one shouldn't even cast on the same target, as long as the remaining duration is longer than that of the DR reduced 2nd effect.

The cast should fail with the client saying: "A more powerful effect is already active"

haephaistoss commented 3 months ago

Some update:

https://www.youtube.com/watch?v=-J55f0puu9A&t=295s - check the slows and application prevention.

Same goes for expose armor - sunder armor etc.

https://wowwiki-archive.fandom.com/wiki/Debuff?oldid=2206058

UltraNix commented 3 months ago

Fixed.

haephaistoss commented 3 months ago

Awesome thanks, it was rly fast!

Gonna check it once back home next week!🫡😇