gamefreedomgit / Frostmourne

3 stars 1 forks source link

BCB and Dual Wielding. #1333

Open Manpower99 opened 1 month ago

Manpower99 commented 1 month ago

Description: Talent BCB seems to interact similarly to how Hack and Slash for rogue works.(offhand hit procs mainhand's damage) it should not, It should use the respective damage range for the weapon that proced it and be appropriately reduced in damage from dual-wielding or in the case of two weapons being vastly different in their damage range, be reduced by both the dual-wielding damage penalty and the weapon range difference itself.

How to reproduce: Equip a fast low level weapon on offhand and a Havoc Heroic in mh. Hit dummy enough Notice how each hit there is barely any variance at all. Now do swap the weapons with the fast low level weapon being put into mainhand instead and observe.

How it should work: BCB works in a simple way in wotlk it has a fixed chance to proc dependant on how many talent points invested to do the damage it should, it should have no icd what so ever. it should hit for the appropriate amount depending on which weapon procced it. This is a old wotlk og video of a frost dk and you can see the damage variance in his scrolling battle text whenever BCB procs

Classic WotLk works exactly the way it is intended also : image

https://classic.warcraftlogs.com/reports/z17wmJNyfAaXq34G#fight=19&type=damage-done&source=14&ability=61895 Logs from classic are also indicating the damage variance.

Database links: https://www.wowhead.com/wotlk/spell=49628/blood-caked-blade

Manpower99 commented 1 month ago

Looking at uwulogs on private servers where this functions correctly they have two db spell ids for Mainhand hits and Offhand Hits Offhand and Mainhand

This is a Log from a different private server where the variance can be seen in the detailed damage on MH and OH hits. and Here is a recent Log from Whitemane showing the lack of massive variance and only Mainhand version proccing.

Karsenity commented 1 month ago

Even though this isn't the original behavior, maybe this would be a good change to keep.

The dps increase is pretty minor, but it's enough that it disincentivizes unholy dk's from targeting tank weapons like Last Laugh since they'd gain more benefit from slow weapons in the MH. Considering that's been a big source of loot drama on the server, that sounds like a good tradeoff.

Manpower99 commented 1 month ago

If they decide to keep the currently incorrect way of it working, then so be it. im only reporting how it should work.