gamefreedomgit / Frostmourne

3 stars 1 forks source link

Deep Wounds and Trauma #1378

Closed Manpower99 closed 1 month ago

Manpower99 commented 1 month ago

Description: Tested this on Ptr with no trinkets or procs. When you get the talent Trauma (increases bleed damage taken by the target by 30%), warrior's Deep Wounds does 69% more instead of 30% more (x1,69 instead of x1,30). This could be because deep wounds takes 30% from the talent twice into the formula, which results in 69% total increase. This bug does not seem to affect other dots, like rend. Every test is conducted on Heroic Training Dummy

How to reproduce: Crit on Dummy once with a twohander with Deep wounds Talented. in my test deepwounds tick for 113damage Rend tick is 589

Crit on a Dummy with the same setup just add 1 points in Trauma now each Deepwounds tick is 149 (a 31% increase from 113tick) Rend tick is 677 ( a 14% Increase from 589tick)

Crit on a Dummy with the same setup just add 1 more point (total of 2 invested talent points) in Trauma now each deepwounds tick is 191 ( 69% increase from 113tick) Rend tick is 765 (a 29% increase from 589tick)

Perhaps it is double dipping if the Warrior is talenting the talent itself i cannot be certain but i have conducted this test multiple times and concluded it is doing way more damage than it should. especially since this is a growing dot like ignite so the accumulative damage will grow too much.

After further digging this seems to be an old sunwell bug that was never fixed : https://youtu.be/wY2w9cgbcPg

How it should work: Rank 1 Truma should increase Bleed Damage by 15% Rank 2 Trauma Should increase Bleed Damage by 30% Mangle Should increase Bleed Damage by 30% Deep Wounds should only benefit once in the formula not twice.

Edit: it would seem Deepwounds simply takes into account any Bleed Increase Debuff Twice As with the comments below, tested with both Trauma and Mangle, the formula likely just takes one of the two debuffs twice into account. Should Be Trauma R2/Mangle>Trauma R1. and ony taking it into the formula once.

Database links: https://www.wowhead.com/wotlk/spell=46855/trauma

AlucardHellsingChapel commented 1 month ago

Did you take blood frenzy into account ?

AlucardHellsingChapel commented 1 month ago

also hitting dummy only once per test well there goes your avg result to trash as you could have gotten any proc etc

Manpower99 commented 1 month ago

Blood Frenzy was not talented. also as i have written there was no trinkets or procs.

Gruonden commented 1 month ago

So I tested it as well. It seems that it’s more about Deep Wounds than Trauma itself. I also tested it with a feral cat. The Mangle debuff (30% more damage from bleeds) provides the same amount of damage increase as Trauma. However, only warriors benefit more from debuff than they should. For example, Rake and Rip benefits a 30% damage increase and Deep Wounds about 60%. Here are the results:

CAT: Rake: 470 ticks without Mangle/Trauma vs. 611 tics with Mangle/Trauma. Rip: 559 tics without Mangle/Trauma vs. 726 tics with Mangle/Trauma. WARRIOR: 122 tics without Mangle/Trauma vs. 206 tics with Mangle/Trauma (with only 1 stack of Deep Wounds).

The tests were performed without any procs (neither talent procs nor item procs)

Manpower99 commented 1 month ago

So I tested it as well. It seems that it’s more about Deep Wounds than Trauma itself. I also tested it with a feral cat. The Mangle debuff (30% more damage from bleeds) provides the same amount of damage increase as Trauma. However, only warriors benefit more from debuff than they should. For example, Rake and Rip benefits a 30% damage increase and Deep Wounds about 60%. Here are the results:

CAT: Rake: 470 ticks without Mangle/Trauma vs. 611 tics with Mangle/Trauma. Rip: 559 tics without Mangle/Trauma vs. 726 tics with Mangle/Trauma. WARRIOR: 122 tics without Mangle/Trauma vs. 206 tics with Mangle/Trauma (with only 1 stack of Deep Wounds).

The tests were performed without any procs (neither talent procs nor item procs)

Thank you for your tests, it is likely an issue within deep wounds's code itself benfitting from both the debuff and another multiplier if the warrior has talented Trauma ( so arms warriors only) ,further evidenced by that fury warrior's deep wounds does not seem to be benefitting twice(will do tests on fury later to fully confirm this) Edit: Look on comment below this.

Gruonden commented 1 month ago

@Manpower99 It seems that this also applies to Fury Warriors. You don’t need to invest any points in the Trauma talent to achieve over a 60% damage increase from the bleed debuff (Mangle).

As Fury Warrior: 118 ticks without debuff, 198 ticks with debuff active. That is not 30% increase but rather over 60%.

Additionally, Deep Wounds is calculated based on the weapon with which you scored a crit strike, so if you crit with your off-hand weapon, your deep wounds will tick for lower amount of damage (73 without debuff, 123 with debuff - also over 60% increase). But honestly , I dont know if it suppose to work like that or not so I will just leave it here.

Manpower99 commented 1 month ago

@Manpower99 It seems that this also applies to Fury Warriors. You don’t need to invest any points in the Trauma talent to achieve over a 60% damage increase from the bleed debuff (Mangle).

As Fury Warrior: 118 ticks without debuff, 198 ticks with debuff active. That is not 30% increase but rather over 60%.

Additionally, Deep Wounds is calculated based on the weapon with which you scored a crit strike, so if you crit with your off-hand weapon, your deep wounds will tick for lower amount of damage (73 without debuff, 123 with debuff - also over 60% increase). But honestly , I dont know if it suppose to work like that or not so I will just leave it here.

Okay good find, then it seems the issue is entirely within deep wound's code regardless of Trauma being talented or not

Manpower99 commented 1 month ago

By Gruonden's finding then it is irrelevant if the warrior is fury or arms, trauma talented or not, the issue seems to be by deepwounds itself benefitting twice from Trauma/Mangle bleed increase.

yeagerca commented 1 month ago

Additionally, Deep Wounds is calculated based on the weapon with which you scored a crit strike, so if you crit with your off-hand weapon, your deep wounds will tick for lower amount of damage (73 without debuff, 123 with debuff - also over 60% increase). But honestly , I dont know if it suppose to work like that or not so I will just leave it here.

That is intended. Criticals that came from main-hand will use main-hand weapon damage, off-hand will use off-hand, and non-weapon spells will use main-hand.

UltraNix commented 1 month ago

Fixed.

Manpower99 commented 5 days ago

Has been in fact reverted as of i'd assume 2 weeks ago perhaps longer. Uwulogs clearly indicate this, wether or not its intended i cannot confirm but evidence show that the revert is intended but there is no basis for why this bug should exist as it contradicts every finding from classic wotlk. not a single high end warrior in classic knew of such bug even on Fight Club Discord.

RealDerpyDude commented 4 days ago

https://youtu.be/hoF0KpGzzf4