search

gamefreedomgit / Frostmourne

3 stars 1 forks source link

[DK] Desolation #1424

Closed Miguelsanx closed 2 months ago

Miguelsanx commented 3 months ago

Description: Blood strike has a minimal chance of not proc Desolation

How to reproduce: It's difficult to reproduce since it only happens 2 out of 100 times, but I'll attach a Twitch clip where it occurs

How it should work: Desolation is a talent in the Unholy tree for Death Knights, giving the Death Knight a 5% increase in all damage each time the player casts Blood Strike.

Database links: https://www.twitch.tv/gono12x/clip/WildWildJellyfishPunchTrees-wjav6sMk5BLPx14v?filter=clips&range=7d&sort=time. At 0:15 seconds https://imgur.com/a/CPoG2We https://www.wowhead.com/wotlk/spell=66817/desolation

Miguelsanx commented 3 months ago

Another clip when it happen https://clips.twitch.tv/EasyDifficultTubersBrokeBack-iAfff1mLlvLlE4FO

Manpower99 commented 3 months ago

Yeah it still happens ( both ptr and live )

Miguelsanx commented 3 months ago

another clip https://clips.twitch.tv/FitFitEmuPogChamp-xm92PJGYyXAcEELp

Miguelsanx commented 3 months ago

when gonna fix that its so annoying https://clips.twitch.tv/FriendlyCheerfulKittenPeoplesChamp-dWVY312ZhwCqP5tP

Manpower99 commented 3 months ago

yeah i dont get it either its legit been happening for so long..

Riztazz commented 3 months ago

Any chance someone could try reproducing this outside of raid environment? I can't even reproduce it once so i don't know what to fix :( I want to exclude it is not some stacking issue

Manpower99 commented 3 months ago

Any chance someone could try reproducing this outside of raid environment? I can't even reproduce it once so i don't know what to fix :( I want to exclude it is not some stacking issue

Issue is that it is SUPER random when it happens, the bloodstrike is not missed, not blocked, not parried and dodged either. and yet the desolation buff isnt applied. it happened there in his recorded vod not sure how to reproduce it lol

Riztazz commented 3 months ago

Yeah i understand, i've been spamming blood strike for an hour and each applied desolation. I'll think of code to replicate the buffs he had and check then, my only guess at the moment is some stacking rule disallowing application of the aura. The request still stands, if someone has some time and want to test it on a dummy and manages to reproduce it on a dummy, please let me know

Riztazz commented 2 months ago

Ok, i have found the issue, testing the fix and pushing, will close once it's live