gamefreedomgit / Frostmourne

3 stars 1 forks source link

Missile Barrage proc should be consumed at the beginning of Arcane Missiles cast. #1716

Closed oneadanut closed 1 month ago

oneadanut commented 2 months ago

Description: Missile Barrage talent gives you a chance to reduce your next Arcane Missiles cast by 2.5 and cost no mana etc.

How to reproduce: Cast Arcane Blast until you get Missile Barrage proc, then use Arcane Missiles.

How it should work: The proc should be consumed at the moment of casting Arcane Missiles, not at the end of channeling.

Because of this bug, it conflicts with T8 4 set bonus. I tested on PTR with the T8 4 set bonus where you have a chance for this proc to not be consumed for the spell which benefits (you can do 2 Arcane Missiles in a row benefiting the proc). The T8 4 set bonus works correctly on fire spec, just on arcane spec it doesn't work because of this bug (not consuming the proc on beginning of Arcane Missiles)

Database links: Check any video related to Arcane mage https://youtu.be/Co2UEsJLHoM?si=EQmqkSP6SA7ZZy5l&t=170

Riztazz commented 2 months ago

https://youtu.be/jD4Ds6f_6wo?t=273

Saving in case of complaints:P this confirms the bug

oneadanut commented 2 months ago

Also, arcane blast debuff doesn't reset at the moment of casting arcane missiles, but I hope the fix doesnt interfere with the damage of it. I think it's a general bug regarding channeling spells, not consuming the buff on the cast, but in the end of it

Riztazz commented 2 months ago

Another issue for arcane blast please :P fixed the missile barrage as it is individual case, will close once it's live

oneadanut commented 1 month ago

The problem with Arcane Missiles was fixed, but T8 4 set bonus is still not working for Arcane spec. I tested on PTR, I did around 30 Arcane Missiles on Missile Barrage proc, but T8 4 set bonus didn't proc once. The T8 4 set bonus for Mage has a chance for Missile Barrage to not be consumed when casting the spell which benefits (in this case Arcane Missiles) allowing you to cast another Arcane Missiles with Missile Barrage proc.

Riztazz commented 1 month ago

Ok, i'll take a look

oneadanut commented 1 month ago

Another issue for arcane blast please :P fixed the missile barrage as it is individual case, will close once it's live

I created a new issue for Arcane Blast which has 2 bugs: https://github.com/gamefreedomgit/Frostmourne/issues/1776

Riztazz commented 1 month ago

Fixed will close once it's live