search

gamefreedomgit / Frostmourne

4 stars 1 forks source link

Warrior: Too low proc chance on sword specialization #1970

Open vedude opened 2 months ago

vedude commented 2 months ago

Description:

I tried some sword specialization today and the proc rate is too low. You do not notice the 6 sec internal cooldown since it takes quite long time for a proc to occurr.

How to reproduce:

Do normal rotation and check the results. It is too low, far below 10% of all your melee attacks.

How it should work:

10% chance on all melee attacks. That includes sunder armor and hamstring etc.

Manpower99 commented 2 months ago

Shouldn't include Sunder or Hamstring, but it should include every yellow hit that does damage. image Hamstring used to do damage in vanilla/tbc which is why it had a chance to proc it, if it can proc it in this server then thats a bug, And Likely it does exist as a bug here as the previous iteration of Blinkstrike/Sun Lute was able to be procced from hamstring and it is functionally the same as an ExtraAttack.

Piootrek commented 2 months ago

I did some tests and Sword Specialization has a correct proc rate and correctly procs from yellow hits. You probably thought it didn't proc, because it's not always visible in recount. Sometimes it appears as just "Melee", not "Melee (Sword Specialization)". It looks like a recount bug.

Shouldn't include Sunder or Hamstring, but it should include every yellow hit that does damage. image Hamstring used to do damage in vanilla/tbc which is why it had a chance to proc it, if it can proc it in this server then thats a bug, And Likely it does exist as a bug here as the previous iteration of Blinkstrike/Sun Lute was able to be procced from hamstring and it is functionally the same as an ExtraAttack.

Do you have any proof it shouldn't proc from Hamstring and Sunder Armor?

Manpower99 commented 2 months ago

I did some tests and Sword Specialization has a correct proc rate and correctly procs from yellow hits. You probably thought it didn't proc, because it's not always visible in recount. Sometimes it appears as just "Melee", not "Melee (Sword Specialization)". It looks like a recount bug.

Shouldn't include Sunder or Hamstring, but it should include every yellow hit that does damage. image Hamstring used to do damage in vanilla/tbc which is why it had a chance to proc it, if it can proc it in this server then thats a bug, And Likely it does exist as a bug here as the previous iteration of Blinkstrike/Sun Lute was able to be procced from hamstring and it is functionally the same as an ExtraAttack.

Do you have any proof it shouldn't proc from Hamstring and Sunder Armor?

Its always proccing from any hits from a sword (oh or mh) and always procs mainhand as a white hit if it procs(even if mainhand isnt a sword), same as rogue HacknSlash, and similarly in vanilla Shield Slam was not able to proc windfury attacks both totem or sword spec because it wasnt hitting with a sword. evidence isnt very conclusive besides classic wow but the only thing that i could confirm is that if the spell requires a weapon and in that slot its a sword, the spell can proc it. https://www.wowhead.com/wotlk/spell=12815/sword-specialization#comments:id=186326 Both Sunder and Hamstring have Require mainhand weapon flag, so as long MH weapon slot has a sword they both can proc it as it seems. image