gamefreedomgit / Frostmourne

1 stars 0 forks source link

(Warrior Deep Wounds) Melee Critical strike chance and Spell Critical strike chance are not normalized like they should be #704

Open mariobrose2 opened 1 month ago

mariobrose2 commented 1 month ago

https://github.com/azerothcore/azerothcore-wotlk/issues/13431 https://www.wowhead.com/wotlk)](https://www.wowhead.com/wotlk/news/wrath-classic-hotfixes-october-14-deep-wounds-and-fiery-weapon-329368

Description: Currently melee crit chance and spell crit chance are not normalized. What this means is that if you have 50% crit chance from gear in your character sheet for example as a warrior, then spell procs such as fiery weapon or saronite bombs should also inherit said critical strike chance. As you can see in the first link I posted, theres a github report from another server that includes all type of evidence from OG Wrath and WotLK classic that backs up this claim, and in the second link a blue post from Blizzard themselves confirming this interaction when they decided to nerf spell crits proccing Deep Wounds in WotLK classic. Although deep wounds DOES CURRENTLY PROC from spell crits and such on Frostmourne PTR, the crit chance on these spells (Fiery weapon for example) is super low since spell crit is not being normalized with melee crit chance, which defeats the purpose of these items since your spell crit chance ends up being super low! Heres a list of items and enchants that can help testing and reproducing said problem.

How to reproduce: Log into the PTR and hit the dummy with a preraid bis warrior with fiery weapon enchant on both weapons, then smack the dummy for a while and see that your fiery weapon spell crits are A LOT lower than your melee auto attack crits.

How it should work: The crit chance on Fiery Weapon or any spell criticals should be the same as the one displayed on the character's melee crit chance sheet.

Below theres some pictures that show the critical strike chance of my melee hits v/s fiery weapon crits, which are basically the same as the values displayed in the character sheet (34,15% melee crit chance and 10,72% spell crit chance)

character sheet fiery weapon crits melee crits

Youtube videos ( From WOTLK Classic retail but before the blizzard's change mentionned above) :

https://www.youtube.com/watch?v=eutQ-HGcWFY

https://www.youtube.com/watch?v=EXt7Mn5Gh9c

Database links: https://www.wowhead.com/wotlk/spell=12867/deep-wounds

mariobrose2 commented 3 weeks ago

bump