gamefreedomgit / Maelstrom

26 stars 6 forks source link

Hit chance is bugged #4900

Closed Feathalise closed 12 months ago

Feathalise commented 1 year ago

Description: I should be hit capped but I miss attack

How to reproduce: My hit chance is 8.08% image but as you can see I still miss attacks image same with pets, when the hunter is hit capped pet should be expertise capped, but pet also misses image

How it should work: I should not miss attacks at 8% hit rate

Database links:

Renehadox commented 1 year ago

The same works for PvP and expertise...

UltraNix commented 1 year ago

@Feathalise More info please: what class? Against what mob/boss/player class?

Feathalise commented 1 year ago

Hunter beastmaster, i discovered this while in BD, I later tried it in the dummy boss and continues to happen there so its not specific to one or two bosses @UltraNix

oldspices commented 1 year ago

shaman thunderstorm is getting lots of misses when i am well over hit cap and never miss any other spells!!

Feathalise commented 1 year ago

as a side note I dont think its specific to ability either, let me hit the dummy for a while, im sure all abilities will miss

Feathalise commented 1 year ago

pet melee image

pet bite image

auto shot image

Feathalise commented 1 year ago

also pet having 25% of melee being glancing blows greatly reduces damage

Feathalise commented 1 year ago

So as of right now hit capped is bugged, next time im at a raid ill make sure to take a look at missed abilities, but this should be plenty already, probably hit formula is bugged because if other classes report the same issue then I assume its that, a bug somewhere is making hit cap slightly bigger then it is.

Im not going to reforge all my gear but I assume if I raised my hit cap by a bit I probably wont miss, but thats a bug

Pornoodemon commented 1 year ago

With 5% Hit chance, my Felguard pet sometimes misses when I use stun. So this problem is most likely of a general nature.

bonfax4 commented 1 year ago

Pet hit/expertise I remember there were issues before but is "bd" you mentioned BwD ? There's a boss in there that reduces hit chance so you need to be specific. And the 2nd set of pictures you posted shows no misses, only "blocks".

No misses or dodges here on raider's trainign dummy, made sure I was atacking from behind so no blocks happened :

6609e0a0d6aea81e4d09995465d02f58

b5ec658f6779fa3310c8985a220384a4 a8780e0a681ea02dd910e34e7293c40c 17a071c5c579d58ce706cc55d3fb1f0f

7c6fabcf78aa6a40e209180960f3268d

Feathalise commented 1 year ago

you can see from my pic what boss it is, its the scientist guy, also you shouldnt get blocks either way, attacking from the back is no solution as its not realistic scenario for raiding, other people also report hit chance issues, so there is something there but not for meto figure out as I no longer play here, good luck with that

bonfax4 commented 1 year ago

You're wrong about that, certain bosses can block and positioning shouldn't be an issue anyway since the tank should be facing them away generally.

Yes, they can block. They even block hunter shots (at least on cata), so you shouldn't shot them from the front. Very minor dps loss anyways.

bonfax4 commented 1 year ago

either way i guess @Ultranix can go test hit against maloriak or maloriak adds to see what's the issue. I can't replicate this on anything else currently.

UltraNix commented 1 year ago

Also tested and also can't reproduce it with my hunter spells/auto shot, nor with pet abilities. So yeah - @Feathalise we would need more info or you can poke me on Discord and let me see if it still happens.

bonfax4 commented 1 year ago

With 5% Hit chance, my Felguard pet sometimes misses when I use stun. So this problem is most likely of a general nature.

There's still certain scenarios where you can miss while "hit capped" btw with phys abiltiies at least. Ex : against Nelf players. You guys should take SS's of these scenarios and post to account for every variable.

bonfax4 commented 1 year ago

Yh nvm, testing 5% hit vs lvl 85 dummies on warlock Felguard and i see misses and dodges.

bf2bfd205cbc665453ba469c3ed8502c

bonfax4 commented 1 year ago

Yh i think whatever formula is being used should account for target level and level caps but it always assumes your max spell hit cap , so you still need 17% against lvl 85's.

Should be smthing like this for expertise : [ spellhit * (exp cap against target lvl) / (hit cap against target lvl ) ]

Pornoodemon commented 1 year ago

With 5% Hit chance, my Felguard pet sometimes misses when I use stun. So this problem is most likely of a general nature.

There's still certain scenarios where you can miss while "hit capped" btw with phys abiltiies at least. Ex : against Nelf players. You guys should take SS's of these scenarios and post to account for every variable.

With a 5% chance of hitting, pet attck missed in pvp with different classes mage, dk, warrior at the start of the duel Moreover, this began to happen recently, 2-3 weeks... I didn’t notice any miss before.

UltraNix commented 1 year ago

But wait - since when 5% is hit cap?

bonfax4 commented 1 year ago

Against lvl 85. He's talking about pvp.

Tested and felguard is missing/dodging with 5% against lvl 85 as shown above. I even tested with 10% and still missed.

UltraNix commented 1 year ago

Tested and felguard is missing/dodging with 5% against lvl 85 as shown above. I even tested with 10% and still missed. How you modified that? Simply adding items with spell hit? Or maybe some aura/talent with spell hit?

Pornoodemon commented 1 year ago

Tested and felguard is missing/dodging with 5% against lvl 85 as shown above. I even tested with 10% and still missed. Как вы это изменили? Просто добавлять предметы с помощью заклинания? Или, может быть, какая-нибудь аура/талант с попаданием заклинания?

I have 5% accuracy solely from items of equipment.

UltraNix commented 1 year ago

Hmm. But 5% spell hit is not 5% melee hit chance. So you are only 5% spell hit (17 is cap as I recall), so your pet is proportionally melee hit chance. 5/17 = 0,3 0,3*8 = 2,4.

Pornoodemon commented 1 year ago

image I thought my pet took spell accuracy In melee combat there is a 1% miss chance. I'll try to add accuracy so that the miss chance is 0% in close combat and watch the pet But bonfax4 checked by 10% and also missed.

UltraNix commented 1 year ago

Warlock pets take your spell hit and converts it to melee hit. It's not 1:1 ratio (the same goes for expertise)

bonfax4 commented 1 year ago

I tested 5, 10 and then 17% and that's when I didn't miss. My point is why is 17% being assumed in a formula against a lvl 85 ? 17 would be against a lvl 88 or boss lvl.

Don't you think if 17% ( following your formula you posted, 17 is the hit cap ) was the pvp spellhit cap for pets that pvp guides wouldn't mention it ? Or that there would be at least a mention of it in discussions ?

17 is not even reachable with full pvp gear if we're being honest, unless you equip some pve hit trinkets and reforge away from every stat.

bonfax4 commented 1 year ago

Missing spell lock/seduction would be critical in 3v3

Pornoodemon commented 1 year ago

Warlock pets take your spell hit and converts it to melee hit. It's not 1:1 ratio (the same goes for expertise)

Well, the fact of the matter is that, as far as I know, 100% of the warlock’s accuracy should be transferred to the pet. For example, the same as resilience And even in all pvp guides the accuracy cap is indicated at 4%.

bonfax4 commented 1 year ago

Btw simc does show that spell hit converts 1:1 to melee hit for lock pets but I dunno if this was actually tested or made purely for the sake of simplicity. No idea how blizzard actually calculates this stuff but I'll hop on retail wotlk ptr tomorrow and test.

UltraNix commented 1 year ago

@Pornoodemon Any links to these guides?

Pornoodemon commented 1 year ago

@PornoodemonЕсть ссылки на эти руководства? And also in all video guides the accuracy is 4% https://www.youtube.com/watch?v=NGElZ1oBSCI

This is just a series of 5-7 text-guides that I came across over the course of 7 years of playing Wow. And they were mostly in Russian. image

UltraNix commented 1 year ago

C'mon - I don't know Russian :P

bonfax4 commented 1 year ago

Pretty sure it's 5% in cata, 4% is wotlk.You can even confirm this on char panel

Edit: Nvm, it's 4% spell hit for pvp combat. 5% mellee.

Pornoodemon commented 1 year ago

C'mon - I don't know Russian :P Video guides also generally have a 4-5% max cap in pvp https://youtu.be/NGElZ1oBSCI?si=L5-k6jNVJ2_Xdh_a&t=26

UltraNix commented 12 months ago

Fixed.