gamefreedomgit / Maelstrom

24 stars 5 forks source link

Dungeon finder tool: dungeon guide display issue #5152

Open Sungis18 opened 9 months ago

Sungis18 commented 9 months ago

Description: When a dungeon's guide (the player with the green flag on his portrait) levels up, there's a bug where it displays that the new dungeon guide is "Unknown" player. Right after a few seconds, it displays the same message telling that the initial dungeon guide is now the new dungeon guide.

So it seems that leveling up a dungeon guide player makes the dungeon not know who's the dungeon guide for a few seconds.

How to reproduce: Go in dungeon, see the dungeon's guide level up, the message will appear.

How it should work: The dungeon guide change message should display only when another player is chosen as the dungeon guide.

PS: I don't have screenshot since I leveled up all my characters atm., if someone can provide one, would be greatly appreciated.

Sungis18 commented 9 months ago

Adding some precisions: the 2nd message (telling the initial dungeon guide is the new dungeon guide) appears just after the dungeon guide is rewarded with experience (or kills a creature I can't figure it out).

The dungeon guide is the played flagged PLAYER_ROLE_LEADER: https://github.com/The-Cataclysm-Preservation-Project/TrinityCore/blob/master/src/server/game/DungeonFinding/LFG.h#L33