search

gamejolt / issue-tracker

Issue tracker for Game Jolt
26 stars 6 forks source link

Client doesn't work with .deb files #408

Closed cammySashimi closed 8 years ago

cammySashimi commented 8 years ago

I'm not sure if it even should, considering the client (probably) works for most Linux distros, but at the moment it "installs" games packaged as .debs and when you click the run button it does absolutely nothing.

I don't know how it handles Windows installers, but maybe it could use a graphical frontend for dpkg or open a terminal or something?

Example game: http://gamejolt.com/games/tinfoil-forest/43391

CyberKiller40 commented 8 years ago

(user opinion) Personally, I don't think it's a good idea to handle any kind of system-wide game installers, regardless of platform. This might make uninstalling such games from the client quite problematic. Not to mention security concerns - potentially malicious software (or just plain unstable - we're talking homebrew here), installing it as root, yeah...

For deb and rpm, the client could unpack them and run the game in place, for other installers this would depend on the archive format they use. Overall, not a really full proof solution IMHO, better to just stick to normal archives.

cammySashimi commented 8 years ago

I agree, but I'm not sure what it currently does with Windows installers. Is it also possible to unpack those and run them in place?

Tricky1975 commented 8 years ago

I also found out that Mac's .dmg files are not properly supported either. (#422) And I guess when it comes to deb and rpm, they are distro related. Not all Linux distros support them, and if those files call for dependencies things can get complicated as not all dependencies are recommendable for all distros. I do not have a full Windows computer at my disposal, but the games I've currently on GameJolt containing installers for Windows are noted as "stand-alone executable", so it's my guess GameJolt does not see the difference between an installer for Windows and an actual game, meaning that I deem it most likely that the client will think the installer is the game itself, since most installers are .exe files anyway. Of course there are also .msi files, but I'm afraid these files can contain more than just the files to copy and that can become pretty hard to cover all.

I think sticking to classic archives such a zip, 7z and rar might be best indeed.

CyberKiller40 commented 8 years ago

@Tricky1975 I think your idea with giving the download for the user is actually pretty good. So if the file is a dmg, msi, rpm or deb, then the user gets the file to install it by themselves. Or there could be a checkbox for game devs to set if the file is an installer of any kind.

Tricky1975 commented 8 years ago

Ah, yeah, I placed that suggestion in #422, but what I said about the mac's dmg files there does indeed also apply for debian's deb files and red hat's rpm files and of course windows' msi files. A checkbox for being an installer would indeed be perfect as some installers (particularly for windows) are stand alone executables, and in the same manner a mac's ".pkg" bundle could also be covered (though I never found somebody on gj using that) :)

YLivay commented 8 years ago

Will be handled in #516 :)