Code cleanup and move common functions and consts to separate files

gameknife / gkNextRenderer

A Modern gkRenderer

15 stars 2 forks source link

Code cleanup and move common functions and consts to separate files #2

Closed tigrazone closed 2 weeks ago

tigrazone commented 2 weeks ago

I dont understand why you use hardcoded consts like 0.5f / 180.f 3.14159f, 45.f / 180.f 3.14159f and vec3(0.0072f, 1.0f, 0.0034f). Maybe better to use it as consts?

gameknife commented 2 weeks ago

Appreciate that! This project is under a time sensitive develop status, some refactor job always delayed... I'm happy to accept this works, I will merge this after work.

tigrazone commented 2 weeks ago

I will check and fix. Please wait

tigrazone commented 2 weeks ago

done. please check. I use only RayTracingRenderer

gameknife commented 2 weeks ago

PR accepted, 🤝