search

gameknife / gkNextRenderer

A Modern gkRenderer
15 stars 2 forks source link

typo? #7

Closed tigrazone closed 1 week ago

tigrazone commented 2 weeks ago

https://github.com/gameknife/gkNextRenderer/blob/bbb414c6db0adcdba63f2e3a99b448b1828f30e3/assets/shaders/Scatter.glsl#L33 but here is https://github.com/gameknife/gkNextRenderer/blob/bbb414c6db0adcdba63f2e3a99b448b1828f30e3/assets/shaders/HybridDeferredShading.comp#L225

Which variant is correct? cos(0.5f / 180.f 3.14159f) or cos(0.25f / 180.f 3.14159f) ???

gameknife commented 2 weeks ago

just magic number... like the "sun angle" in UnrealEngine, for soft shadow penumbra