search

gameknife / gkNextRenderer

A Realtime PathTracer
50 stars 4 forks source link

RayQuery renderer in new release is slower than previous releases #81

Closed tigrazone closed 1 month ago

tigrazone commented 1 month ago

I checked in benchmarks with same models files from release 1.0.9 (get assets/models from 1.0.9 and replace 1.0.8 and 1.0.7 same folder to newer) and I see new release RayQuery renderer works slower. zip with reports Can you revert to fastest version in new release?

tigrazone commented 1 month ago

one more question. how to off denoiser in benchmark mode? when I off denoiser in renderer mode, not in benchmark mode and set Samples to 1 then speed of renderer start to be like in previous version

tigrazone commented 1 month ago

how to off denoiser in benchmark mode

seems denoiser is always on and no way to make it off https://github.com/gameknife/gkNextRenderer/blob/8a32c68bf1ae1e69cef30de0bc80e2b77df927a9/src/Options.cpp#L26

I propose to change to default_value(false) and if needed use --denoiser in command line

gameknife commented 1 month ago

new jbf denoiser is default on, the cost is acceptable and make a quality boost. I will change --denoiser to --nodenoiser in the commandline

gameknife commented 1 month ago

fixed in https://github.com/gameknife/gkNextRenderer/commit/0cc51b83418333f432d06ed82a495463f920a249