search

gameknife / gkNextRenderer

A Realtime PathTracer
50 stars 4 forks source link

sampling or model issue makes jagged pattern on some models #84

Closed tigrazone closed 1 month ago

tigrazone commented 1 month ago

one more issue is timer doesnt count time issue1 issue2

gameknife commented 1 month ago

seems like you prefer a "progressive rendering on frame" mode, currently the all effort is targeting realtime rendering. this issue is not notice on 16-32 tempral frames.

may be the progressive rendering mode should like the origin "RayTracing in OneWeekend" repo, introduce a float64 accumlate buffer instead off current temporal buffer?

tigrazone commented 1 month ago

I use unchanged your repository. Maybe problem with models

gameknife commented 1 month ago

corner hit may generate wrong normal, add epsilon to fix it. fixed in https://github.com/gameknife/gkNextRenderer/commit/ae8b5ee641eedb4287ac7a49342a5553871a8c16