search

gamelab / kiwi.js

Kiwi.js is a blazingly fast mobile & desktop browser based HTML5 game framework. It uses CocoonJS for publishing to the AppStore.
www.kiwijs.org
MIT License
1.41k stars 194 forks source link

Game prints 'Stage specified' even if no stage was specified. #129

Closed RaniSputnik closed 9 years ago

RaniSputnik commented 9 years ago

The console print is incorrect and that is annoying when debugging. "Kiwi.Game: Stage specified, but is not a valid option. Set to NONE." is printed even if no stage is specified. It should print, "Kiwi.Game: Stage scaling not specified, defaulting to NONE." and "Kiwi.Game: Stage scaling specified, but {value} is not a valid option. Set to NONE." as error text.

danmilward commented 9 years ago

Thanks Ryan. PRs are welcome otherwise thanks for putting it on our Radar :)

On Sun, Dec 7, 2014 at 9:43 AM, Ryan Loader notifications@github.com wrote:

The console print is incorrect and that is annoying when debugging. "Kiwi.Game: Stage specified, but is not a valid option. Set to NONE." is printed even if no stage is specified. It should print, "Kiwi.Game: Stage scaling not specified, defaulting to NONE." and "Kiwi.Game: Stage scaling specified, but {value} is not a valid option. Set to NONE." as error text.

— Reply to this email directly or view it on GitHub https://github.com/gamelab/kiwi.js/issues/129.

Dan Milward

M +64 21 449 901

178 Willis Street – Wellington CBD – Wellington 6011 – New Zealand www.kiwijs.org - www.gamefroot.com http://www.gamefroot.com/leveleditor

BenjaminHarding commented 9 years ago

Thanks Rani. Will update this in the next version :)

danmilward commented 9 years ago

Thanks Ryan. PRs are welcome too :)

Sent from my iPhone

On 8/12/2014, at 8:34 am, Benjamin notifications@github.com wrote:

Thanks Rani. Will update this in the next version :)

— Reply to this email directly or view it on GitHub.

BenjaminHarding commented 9 years ago

@RaniSputnik Updated it in the latest version thanks! Turns out it was due to an incorrect conditional which always evaluated to true. Doh