Changes done to logging (JSON, custom delimiter, +++)

gamelinux / passivedns

A network sniffer that logs all DNS server replies for use in a passive DNS setup

http://gamelinux.org/

1.67k stars 372 forks source link

Changes done to logging (JSON, custom delimiter, +++) #38

Closed thus closed 9 years ago

maxtors commented 9 years ago

Regarding my above comments, i could look into it myself if you wanted, and send a pull-request. Unless you don't want to implement my comments or want to do it yourself =)

thus commented 9 years ago

Yes, defined values would probably be better. I was actually considering just dropping the two values you are refering to all together, since they never change, but I wanted the JSON output to output the same values.

Regarding the second comment, it would be probably be better to rewrite print_passet() and print_passet_err() to be one function instead of two. I just haven't gotten around to doing it yet ;)

thus commented 9 years ago

Fixed the defined values in: https://github.com/gamelinux/passivedns/commit/c71c6902b20844616ef7817677acc00f9f4e6f42.

Thanks! :)

hillar commented 9 years ago

Thanks! :)