search

gamelinux / passivedns

A network sniffer that logs all DNS server replies for use in a passive DNS setup
http://gamelinux.org/
1.67k stars 372 forks source link

Redis v1 #70

Open maxtors opened 8 years ago

maxtors commented 8 years ago

Added support to publish log entries on a redis channel. Not sure if everything is up to styling / convention, and probably some stuff needs work. Looking forward to feedback.

thus commented 8 years ago

Thanks for contributing!

I'll wait with any feedback, until you are done applying commits (8 yesterday, 3 new today). In the future, please wait until you are done coding before sending a pull request. It's kind of annoying when code is changing while reading it.

maxtors commented 8 years ago

Sure, thats a good point. Sorry for that. Done with this round of changes (was going to commit todays changes to a new branch though). So ill open a new branch/PR with feedback and or discovered bugs / issues.

thus commented 8 years ago

Sounds good :) I'll take a look at your pull request as soon as I get the chance.

maxtors commented 8 years ago

Have you had a chance to take alook at this?