search

gamemanual0 / gm0

Game Manual 0 - The most extensive guide out there for FTC
https://gm0.org
Other
53 stars 84 forks source link

Basic IMU Example #416

Open Krabbenhoft opened 7 months ago

Krabbenhoft commented 7 months ago

What information should be added? I started working on a draft of possible IMU information. I am hoping to get feedback on if this is headed in the right direction and what major changes need to be made (I still need to review the style guide and maybe expand some things).

https://docs.google.com/document/d/1Pbkl8GGNRPcUUfDdw1RvUQzDddL5vIVZ5e9TMxxhzw8/edit

Does it need it's own page? (Yes/No): Yes

If it needs a page, which section should it be in? If it doesn't, which page should it be under? It should go under the programming tutorials section.

abidingabi commented 7 months ago

Overall, it looks pretty good, but a couple preliminary notes:

Krabbenhoft commented 7 months ago

I am not a very advanced programmer, is it okay to reference using a PID controller and include code that scales the speed according to the percentage of the turn completed?

abidingabi commented 7 months ago

and include code that scales the speed according to the percentage of the turn completed? This is pretty similar to what a P controller is :). A P controller sets the speed to (target - setpoint) * kP, where kP is a tuned constant, so that you slow down as you approach the target so you do not overshoot. Mentioning full-on PID control would be smart, but I think a P controller is sufficient for this example.

Krabbenhoft commented 6 months ago

I have worked more on it. What changes would you still like to see?

abidingabi commented 6 months ago

Most of my suggestions would involve relatively small wording changes. It would be easier to deal with those if you opened a pull request for this, as I could use GitHub review functionality.

Krabbenhoft commented 6 months ago

https://github.com/gamemanual0/gm0/pull/421